Enable merging of groups when objects also in segments #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnsen
changed the title
|
@apdavison do you have any opinions on this? Do we want to move the milestones around? It is still a draft. @kjohnsen Did you want to receive actual feedback on this? Or add testing if Andrew approves of this? We are cleaning up PRs etc. |
|
@zm711 I think this is best left to your judgment since this was a while ago and I don't know the Neo codebase very well in general. I do not have time to add testing myself right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1308.
I don't understand the merge process well enough to know if this behavior is desired for merging. But if it is, this PR should probably add to the test suite for before merging. No tests are broken by this change.