Add group and imagesequence to NeoMatlabIO #1360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zm711
commented
Dec 5, 2023
This is done by saving references to objects inside groups, on the assumption that those objects are already stored somewhere within segments. This assumption may not always be true, so probably we should only save references for objects that would otherwise be duplicated.
Implement support for saving/loading Groups in NeoMatlabIO.
zm711
commented
Jan 26, 2024
| if len(arr) > 0: | ||
| data_complement["spatial_scale"] = arr | ||
| else: | ||
| pass # |
There was a problem hiding this comment.
For an ImageSequence this is required, so passing could mess up an ImageSequence if someone doesn't supply the scale. So I'm not sure if we should instead raise an error since I'm not sure what an appropriate default would be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1358,
here's a starting draft for working on NeoMatlabIO. I tested locally and it worked for writing and reading groups and imagesequences. I added a test for writing/reading imagesequences for the CI. Feel free to give it a read when you have time.
@apdavison