Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hide BossTargetFrameContainer to prevent related erorr #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gillid
Copy link

@gillid gillid commented Aug 24, 2024

Description

The Issue

When "Hide boss frames" option is turned on in SUF, the snap-to-grid feature doesn't work in Blizzard Edit Mode.

Reported on Wowace:

The fix

Calling hideBlizzardFrames on BossTargetFrameContainer seems to fix the problem.
Assumption - a specific event that is causing the issue is unregistered and not being called at all.

Appendix

Error dump

47x ...izzard_EditMode/Mainline/EditModeSystemTemplates.lua:535: attempt to perform arithmetic on local 'left' (a nil value)
[string "@Blizzard_EditMode/Mainline/EditModeSystemTemplates.lua"]:535: in function `GetScaledSelectionSides'
[string "@Blizzard_EditMode/Mainline/EditModeSystemTemplates.lua"]:507: in function `IsVerticallyAlignedWithFrame'
[string "@Blizzard_EditMode/Mainline/EditModeSystemTemplates.lua"]:725: in function `GetFrameMagneticEligibility'
[string "@Blizzard_EditMode/Mainline/EditModeUtil.lua"]:152: in function `GetEligibleMagneticFrames'
[string "@Blizzard_EditMode/Mainline/EditModeUtil.lua"]:341: in function `GetMagneticFrameInfoOptions'
[string "@Blizzard_EditMode/Mainline/EditModeUtil.lua"]:424: in function `GetMagneticFrameInfos'
[string "@Blizzard_EditMode/Mainline/EditModeManager.lua"]:961: in function `RefreshSnapPreviewLines'
[string "@Blizzard_EditMode/Mainline/EditModeManager.lua"]:72: in function <...ddOns/Blizzard_EditMode/Mainline/EditModeManager.lua:70>

Locals:
self = BossTargetFrameContainer {
 systemInfo = <table> {
 }
 downKeys = <table> {
 }
 breakSnappedFramesOnSave = true
 smallSize = true
 spacing = 10
 alwaysUseTopRightAnchor = true
 isManagedFrame = true
 hasActiveChanges = false
 dirty = false
 isHighlighted = true
 systemIndex = 6
 isInEditMode = true
 snappedFrames = <table> {
 }
 ignoreFramePositionManager = true
 isRightManagedFrame = true
 layoutParent = UIParentRightManagedFrameContainer {
 }
 savedSystemInfo = <table> {
 }
 systemNameString = "Рамки боссов"
 BossTargetFrames = <table> {
 }
 isSelected = false
 castBarOnSide = true
 dirtySettings = <table> {
 }
 hideWhenActionBarIsOverriden = false
 settingMap = <table> {
 }
 settingDisplayInfoMap = <table> {
 }
 Selection = Frame {
 }
 settingsDialogAnchor = <table> {
 }
 align = "right"
 respectChildScale = true
 layoutIndex = 4
 defaultHideSelection = true
 system = 3
 rightPadding = -70
}
left = nil
bottom = nil
width = nil
height = nil
scale = 1
(*temporary) = BossTargetFrameContainer {
 systemInfo = <table> {
 }
 downKeys = <table> {
 }
 breakSnappedFramesOnSave = true
 smallSize = true
 spacing = 10
 alwaysUseTopRightAnchor = true
 isManagedFrame = true
 hasActiveChanges = false
 dirty = false
 isHighlighted = true
 systemIndex = 6
 isInEditMode = true
 snappedFrames = <table> {
 }
 ignoreFramePositionManager = true
 isRightManagedFrame = true
 layoutParent = UIParentRightManagedFrameContainer {
 }
 savedSystemInfo = <table> {
 }
 systemNameString = "Рамки боссов"
 BossTargetFrames = <table> {
 }
 isSelected = false
 castBarOnSide = true
 dirtySettings = <table> {
 }
 hideWhenActionBarIsOverriden = false
 settingMap = <table> {
 }
 settingDisplayInfoMap = <table> {
 }
 Selection = Frame {
 }
 settingsDialogAnchor = <table> {
 }
 align = "right"
 respectChildScale = true
 layoutIndex = 4
 defaultHideSelection = true
 system = 3
 rightPadding = -70
}
(*temporary) = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on local 'left' (a nil value)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant