Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 12-hour notification to sensor expiry #3225

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Dec 7, 2023

12 hours has a significance for G7.
It's useful for someone who likes to start their sensor about the same time every 12 hours considering that the sensor runtime is 10 days + 12 hours.

After adding 12 hours, a 9-hour option seems not the best option. So, I moved it to 6 hours.

Edit:
I see that I have a mistake. I meant to say for someone who likes to start their sensor about the same time every 10 days. I didn't mean every 12 hours even though that is what I wrote.

Der-Schubi added a commit to Der-Schubi/xDrip that referenced this pull request Dec 11, 2023
Merge remote-tracking branch 'Navid200/Navid_2023_12_06' into schubi
@jamorham
Copy link
Collaborator

I'm not sure I understand what you're getting at with regards to someone starting the sensor at the same time if there is 12 hour at the end of the session?

I think I didn't choose 12 hours as a time block the first time around was to maybe try to avoid things like the alert triggering in the middle of the night, but maybe that wouldn't work anyway. It is supposed to react somewhat to the user doing things and alert after it becomes due.

@Navid200
Copy link
Collaborator Author

I am putting together a page in the guide explaining the different options one has for using the 12 hour grace period. But, this PR is not about that.

Right now, a G7 user will get a notification if their screen is unlocked at 9 hours before sensor expiry.

Please let me explain one of the three options for using the 12 hour grace period.
The user always inserts their sensor at about 9:00 am.
When they do that, the sensor expiry is in 10.5 days, which will be at 9:00 pm.
If this is merged, in 10 days, they will get a notification at 9:00 am. So, it reminds them to insert their next sensor.

As long as this is not merged, they will get a notification when they have been 3 hours late at 12:00 pm, 9 hours to sensor expiry.

@Navid200
Copy link
Collaborator Author

My understanding is that this is not an alert, it is a notification. The alert only makes a sound if the screen is unlocked.
So, it should make no sound if one is sleep.

@Navid200
Copy link
Collaborator Author

The scenario I have explained allows a new sensor to work for 12 hours before the user starts using it. So, it is like pre soaking for 12 hours. In this scenario, the user uses 9 sensors in 90 days.
But, the sensors always have a 12-hour overlap.

@jamorham jamorham merged commit 8253844 into NightscoutFoundation:master Dec 15, 2023
1 check passed
@Navid200 Navid200 deleted the Navid_2023_12_06 branch December 15, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants