Notify and log failures to upload to Nightscout consistently #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navid200
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading to more than one site, a silent notification is presented and a log is created once a day if there is a failure to upload to one site but not the other.
If some day we add dedicated (per site) queues, all of this will be removed because there will be no need for any of it then.
I am sorry I have added a new setting. Unfortunately, someone may use Nightscout and not care about inconsistent uploads. In that case, having to acknowledge a notification everyday may not be convenient.
Notification
Log
Translations
The notification and its title will be translated.
The log will not be translated.
Tests
This has been tested on Motorola Android 11 and Motorola Android 8.
There is no notification if all uploads fail (no WiFi).
There is notification and log when there is a failure to upload to one site but not the other. By default, the notification is enabled.
Disabling the notification will still generate a log but no notification.
To cause failure to upload to only one site, the Google Cloud Nightscout site was temporarily stopped.