fix newItems from being shuffled on insert

NiloCK · Aug 31, 2022 · 84283ff · 84283ff
1 parent e91d118
commit 84283ff
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/tui/tui.go b/tui/tui.go
@@ -335,7 +335,7 @@ func getFiles(wd string, extensions []string) []string {
 }
 
 func sortItems(items []*tuido.Item) {
-	sort.Slice(items, func(i, j int) bool {
+	sort.SliceStable(items, func(i, j int) bool {
 		if items[i].Importance() > items[j].Importance() {
 			return true
 		}

diff --git a/tui/update.go b/tui/update.go
@@ -181,8 +181,11 @@ func (t *tui) tryCreateNewItem() {
 
 func (t *tui) createNewItem() {
 	newItem := tuido.New(t.config.writeto, -1, "")
-	t.items = append([]*tuido.Item{&newItem}, t.items...)
-	t.populateRenderSelection()
-	t.setSelection(0)
+	t.items = append(t.items, &newItem)
+	// write directly to renderselection instead of repopulating,
+	// to avoid a sorting move before setSelection is called.
+	t.renderSelection = append(t.renderSelection, &newItem)
+
+	t.setSelection(len(t.renderSelection) - 1)
 	t.setEditMode()
 }