prometheus-nixos-exporter: add nix 2.19.0 compat #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
force-pushed
the
nixos-exporter-2.19.0-compat
branch
2 times, most recently
from
62770e1 to
6180cfc
Compare
vcunat
reviewed
Feb 3, 2024
|
Overall I think this is OK to just deploy and see. |
mweinelt
force-pushed
the
nixos-exporter-2.19.0-compat
branch
from
6180cfc to
04e85c0
Compare
Agreed, I just need to bootstrap the VPN on my desktop. |
mweinelt
force-pushed
the
nixos-exporter-2.19.0-compat
branch
5 times, most recently
from
2579616 to
b2db5a7
Compare
The output of `nix path-info --json` changed from a list to an object in nix 2.19.0. Add a simple version detection, so we can support both output formats. Fixes: #346
Reformat the file using `ruff format`.
This wraps the executable into a standard python build, which fixes import lag, due to its previous location in the nix store.
mweinelt
force-pushed
the
nixos-exporter-2.19.0-compat
branch
from
b2db5a7 to
ffa1f35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of
nix path-info --jsonchanged from a list to an object in nix 2.19.0.Add a simple version detection, so we can support both output formats.
Fixes: #346