Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakes: split sources #805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

flakes: split sources #805

wants to merge 1 commit into from

Conversation

wegank
Copy link
Member

@wegank wegank commented Jun 26, 2024

This PR splits flakes/manual.toml into multiple files under flakes/manual/, and modifies .github/workflows/check-flake-files.yml so that it only runs on the modified files.

Copy link
Contributor

github-actions bot commented Jun 26, 2024

@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 12:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 12:38 Inactive
@wegank wegank marked this pull request as ready for review June 26, 2024 12:47
@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 15:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 08:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 09:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 11:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 15:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 20:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 28, 2024 08:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 8, 2024 13:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 29, 2024 14:07 Inactive
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry this took me so long to take a look at.

I really like the direction this is going. This does however only address the PR checks and not the actual import. That would be where the actual issues surface when a downstream flake breaks. So I think we should loop over the groups in the import as well, write them to a yaml (maybe? it should at least be concat'able) and bulk-import that into ES.

@wegank
Copy link
Member Author

wegank commented Oct 15, 2024

Hey, sorry this took me so long to take a look at.

I really like the direction this is going. This does however only address the PR checks and not the actual import. That would be where the actual issues surface when a downstream flake breaks. So I think we should loop over the groups in the import as well, write them to a yaml (maybe? it should at least be concat'able) and bulk-import that into ES.

I've also lost track of the PR, but I think the one-line change in .github/workflows/import-to-elasticsearch.yml does exactly that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants