Apply suggestions from code review

Co-authored-by: Gaétan Lepage <[email protected]>
NixOS · Feb 2, 2025 · 3b6c0e6 · 3b6c0e6
1 parent 1ab1055
commit 3b6c0e6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkgs/development/libraries/valhalla/default.nix b/pkgs/development/libraries/valhalla/default.nix
@@ -28,7 +28,7 @@ stdenv.mkDerivation (finalAttrs: {
   src = fetchFromGitHub {
     owner = "valhalla";
     repo = "valhalla";
-    rev = finalAttrs.version;
+    tag = finalAttrs.version;
     hash = "sha256-v/EwoJA1j8PuF9jOsmxQL6i+MT0rXbyLUE4HvBHUWDo=";
     fetchSubmodules = true;
   };
@@ -47,8 +47,8 @@ stdenv.mkDerivation (finalAttrs: {
 
   cmakeFlags = [
     "-DENABLE_TESTS=OFF"
-    "-DENABLE_SINGLE_FILES_WERROR=OFF"
-    "-DPREFER_EXTERNAL_DEPS=ON"
+    (lib.cmakeBool "ENABLE_SINGLE_FILES_WERROR" false)
+    (lib.cmakeBool "PREFER_EXTERNAL_DEPS" true)
   ];
 
   buildInputs = [