php81: restore patch for libxml2 on darwin #318536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
referenced
this pull request
in php/php-src
Jun 9, 2024
drupol
requested review from
jtojnar,
aanderse,
globin,
Ma27 and
talyz
as code owners
jtojnar
reviewed
Jun 9, 2024
drupol
force-pushed
the
php81/fix-builds-with-libxml2
branch
from
e769c78 to
b09b184
Compare
|
I asked @nielsdos, and I'm waiting for some feedback from @ramsey @patrickallaert to see if that patch can be backported. It would be a pity if we couldn't. |
13 tasks
|
@ofborg build php81 |
PHP 8.1 is in security maintenance and regression fix mode. Unless the patch addresses a security concern or a regression introduced in a prior bug fix, we aren't able to backport the patch. |
|
Successfully created backport PR for |
1 task
|
Git push to origin failed for release-23.11 with exitcode 1 |
|
Successfully created backport PR for |
1 task
|
Git push to origin failed for release-24.05 with exitcode 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch has been removed erroneously in previous PR, I thought it was merged in. Welp, it was not.
This PR restore the patch.
Related to: fossar/nix-phps#346
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.