clever-tools: 3.8.3 -> 3.9.0 #350990
Merged
clever-tools: 3.8.3 -> 3.9.0 #350990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-sanders-cc
force-pushed
the
clever-tools-3-9-0
branch
from
90ea3d5 to
019dfe6
Compare
ofborg
bot
added
11.by: package-maintainer
florian-sanders-cc
force-pushed
the
clever-tools-3-9-0
branch
4 times, most recently
from
c62510c to
2d92307
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4774 |
Scrumplex
reviewed
Nov 1, 2024
florian-sanders-cc
force-pushed
the
clever-tools-3-9-0
branch
3 times, most recently
from
e07a78a to
4e9bbd1
Compare
florian-sanders-cc
force-pushed
the
clever-tools-3-9-0
branch
from
4e9bbd1 to
d8b13b8
Compare
Scrumplex
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
3.9.0,npm run buildscript introduced by the3.9.0release to generate a single.cjsfile that contains the whole CLI code (including its dependencies). This means that:.cjsfile to get an executable file running with theNode.jsversion specified,bin/clever(the wrapped file to be executed by Node),src/clever.cjs(the source.cjsfile containing the actuel CLI code),share/bash-completionandshare/zsh(the completion files).Note that this is the first time I use
makeWrapperso don't hesitate to tell me if stuff can be improved 😉Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.