Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.fsspec: 2024.3.0 -> 2024.12.0; python312Packages.s3fs: 2024.9.0 -> 2024.12.0 #353271

Merged
merged 4 commits into from
Jan 18, 2025

Conversation

natsukium
Copy link
Member

Diff: fsspec/filesystem_spec@refs/tags/2024.3.0...2024.10.0
Changelog: https://github.com/fsspec/filesystem_spec/raw/2024.10.0/docs/source/changelog.rst

Changelog: https://github.com/fsspec/s3fs/raw/2024.10.0/docs/source/changelog.rst

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@natsukium

This comment was marked as outdated.

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should go into staging

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@natsukium natsukium changed the title python312Packages.fsspec: 2024.3.0 -> 2024.10.0; python312Packages.s3fs: 2024.9.0 -> 2024.10.0 python312Packages.fsspec: 2024.3.0 -> 2024.12.0; python312Packages.s3fs: 2024.9.0 -> 2024.12.0 Jan 13, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 13, 2025
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update LGTM

Did not build dependent packages.

@FliegendeWurst FliegendeWurst changed the base branch from master to staging January 13, 2025 15:21
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 14, 2025
@natsukium natsukium merged commit c12baeb into NixOS:staging Jan 18, 2025
42 of 44 checks passed
@natsukium natsukium deleted the s3fs/update branch January 18, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants