Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.weasyprint: 62.3 -> 63.0 #355224

Closed
wants to merge 262 commits into from
Closed

python312Packages.weasyprint: 62.3 -> 63.0 #355224

wants to merge 262 commits into from

Conversation

phaer
Copy link
Member

@phaer phaer commented Nov 11, 2024

Weasyprint got a new release.

  • Updated ffi.py patch
  • updated tinycss2 dependency
  • added tinyhtml5 dependency

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium November 11, 2024 15:35
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 12, 2024
@ofborg ofborg bot requested a review from onny November 12, 2024 04:57
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4828

SuperSandro2000
SuperSandro2000 reviewed Nov 12, 2024
View reviewed changes
pkgs/development/python-modules/weasyprint/default.nix Show resolved Hide resolved
pkgs/development/python-modules/weasyprint/default.nix
Comment on lines 45 to +48
pango = "${pango.out}/lib/libpango-1.0${stdenv.hostPlatform.extensions.sharedLibrary}";
pangocairo = "${pango.out}/lib/libpangocairo-1.0${stdenv.hostPlatform.extensions.sharedLibrary}";
harfbuzz = "${harfbuzz.out}/lib/libharfbuzz${stdenv.hostPlatform.extensions.sharedLibrary}";
harfbuzz_subset = "${harfbuzz.out}/lib/libharfbuzz-subset${stdenv.hostPlatform.extensions.sharedLibrary}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of those we shoudl use lib.getLib

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to block updates with unrelated improvements - as that aspect didn't change with this PR. You are very welcome to update them in a separate one :)

pkgs/development/python-modules/tinyhtml5/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/tinycss2/default.nix Outdated Show resolved Hide resolved
@mweinelt mweinelt force-pushed the python-updates branch 6 times, most recently from 257b53d to 87ba457 Compare November 18, 2024 18:24
@phaer phaer changed the base branch from python-updates to staging November 24, 2024 23:53
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: rust 6.topic: policy discussion 6.topic: golang 6.topic: vim 6.topic: hardware and removed 6.topic: python labels Nov 24, 2024
mweinelt and others added 17 commits January 28, 2025 21:47
@mweinelt
home-assistant-custom-components.versatile_thermostat: init at 7.1.5,…
be1761c 
… home-assistant-custom-lovelace-modules.versatile-thermostat-ui-card: init at 1.1.2 (NixOS#377092)
@khaneliman
vimPlugins: move non-github plugins to separate files (NixOS#376366)
00e2be9
@FliegendeWurst
flex-launcher: init at 2.2 (NixOS#371212)
e7d8d2c
@FliegendeWurst
nanobench: init at 4.3.11 (NixOS#374269)
65e2049
@mweinelt
SDL_ttf: mark vulnerable; appimageTools: drop SDL1 (NixOS#376376)
18d3669
@FliegendeWurst
mp4fpsmod: init at 0.27 (NixOS#333636)
d27bff6
@FliegendeWurst
toybox: 0.8.11 -> 0.8.12 (NixOS#376688)
fa94f96
@FliegendeWurst
timelens: remove (NixOS#376675)
b95a4e7
@misuzu
screen: mark as broken on darwin
d5ea40e 
Disabling PAM doesn't help much.
@FliegendeWurst
lldap-cli: 0-unstable-2024-02-24 -> 0-unstable-2024-11-11 (NixOS#374905)
76ce79f
@dasJ
vim: migrate homepage URL to https:// schema (NixOS#377537)
ba04c81
@Mic92
screen: fix darwin build
a2f04a3
@Mic92
screen: remove unused configureFlags
d0ae116
@misuzu
screen: 4.9.1 -> 5.0.0 (NixOS#375953)
fbc0dac
@GaetanLepage
zed-editor: remove explicit stripDebugList (NixOS#377583)
c8992e8
@phaer
python312Packages.tinyhtml5: init at 2.0.0
a1315c6
@phaer
python312Packages.weasyprint: 62.3 -> 63.0
116e523
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: vim 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jan 28, 2025
@phaer phaer closed this Jan 28, 2025
@nix-owners
Copy link

nix-owners bot commented Jan 28, 2025

The PR's base branch is set to staging, but 260 commits from the master branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the master branch, change the base branch to master
  • If the changes should go to the staging branch, rebase your PR onto the merge base with the staging branch: 
    # git rebase --onto $(git merge-base upstream/staging HEAD) $(git merge-base upstream/master HEAD)
git rebase --onto 64dad1282cc9d01e087d3e4946f7bf85d13316e5 c8992e82d2426155a3ba9f3ec1621e181bdc87c0
git push --force-with-lease

@phaer phaer mentioned this pull request Jan 28, 2025
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@natsukium natsukium Awaiting requested review from natsukium

@onny onny Awaiting requested review from onny

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: emacs Text editor 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.