Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord-rpc: patch with unreleased PR #387 #372219

Merged

Conversation

erratic-pattern
Copy link
Contributor

@erratic-pattern erratic-pattern commented Jan 8, 2025

Things done

Builds of discord-rpc are failing on latest clang. See #371905 for details.

Includes patch of unreleased PR discord/discord-rpc#387 from the unmaintained project which fixes the build error.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@erratic-pattern erratic-pattern force-pushed the patch/discord-rpc/fix-clang branch from 72120a5 to 2ad5b86 Compare January 8, 2025 21:06
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 8, 2025
@erratic-pattern erratic-pattern force-pushed the patch/discord-rpc/fix-clang branch 2 times, most recently from 3fd6f05 to e577468 Compare January 8, 2025 21:21
@erratic-pattern erratic-pattern changed the title discord-rpc: patch with unreleased PRs #306 and #387 discord-rpc: patch with unreleased PR #387 Jan 8, 2025
@erratic-pattern erratic-pattern force-pushed the patch/discord-rpc/fix-clang branch from e577468 to c3f9a8b Compare January 9, 2025 21:07
Copy link
Contributor

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

I tested compilation on x86_64-linux.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 10, 2025
@JohnRTitor JohnRTitor merged commit 4aeb84c into NixOS:master Jan 11, 2025
25 of 28 checks passed
@JohnRTitor
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants