Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseeffects-legacy: 4.8.7 -> 4.8.7-unstable-2024-09-17 #373241

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Tibso
Copy link
Contributor

@Tibso Tibso commented Jan 12, 2025

Fixes #372240

The release 4.8.7 is broken due to a change in the Boost library,
as stated by the owner of the now-renamed "EasyEffects" repository on this comment.
The "pulseaudio-legacy" branch should now be used instead of the 4.8.7 release.

Things done

  • Adapted version
  • Changed rev to the latest commit of the "pulseaudio-legacy" branch
  • Changed the value sha256 to hash and adapted its content
  • Removed the facultative rec keyword

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 12, 2025
@con-f-use con-f-use requested a review from NobbZ January 12, 2025 17:30
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 12, 2025
@Tibso Tibso force-pushed the fix-package-pulseeffects-legacy branch from 1dcdef8 to 9be0e9b Compare January 12, 2025 17:49
@Tibso Tibso force-pushed the fix-package-pulseeffects-legacy branch from 9be0e9b to 8ab6ca7 Compare January 12, 2025 18:03
@Tibso Tibso changed the title pulseeffects-legacy: 4.8.7 -> 4.8.7-unstable-2025-01-12 pulseeffects-legacy: 4.8.7 -> 4.8.7-unstable-2024-09-17 Jan 12, 2025
@con-f-use con-f-use self-requested a review January 12, 2025 18:11
@NobbZ
Copy link
Contributor

NobbZ commented Jan 13, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373241


x86_64-linux

✅ 1 package built:
  • pulseeffects-legacy

aarch64-linux

✅ 1 package built:
  • pulseeffects-legacy

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 14, 2025
@FliegendeWurst FliegendeWurst merged commit 6dc6031 into NixOS:master Jan 14, 2025
41 of 44 checks passed
@Tibso Tibso deleted the fix-package-pulseeffects-legacy branch January 14, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: pulseeffects-legacy
6 participants