Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.netbox-diode-plugin: init at 0.6.0 #374361

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

felbinger
Copy link
Member

The strict dependencies cannot be imported, relaxing them using:

  pythonRelaxDepsHook = [
    certifi
    grpcio
    protobuf
  ];

doesn't work too, so we need the post patch magic:

  postPatch = ''
    sed -i 's/certifi==[0-9\.]*/certifi/' pyproject.toml
    sed -i 's/grpcio==[0-9\.]*/grpcio/' pyproject.toml
    sed -i 's/protobuf==[0-9\.]*/protobuf/' pyproject.toml
  '';

We still get some errors during build:

ModuleNotFoundError: No module named 'netbox'

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: lib The Nixpkgs function library labels Jan 16, 2025
@felbinger felbinger force-pushed the netbox-diode-plugin branch from d2952c9 to eb935e4 Compare January 16, 2025 18:56
@felbinger felbinger changed the title Netbox diode plugin python312Packages.diode-netbox-plugin: init at 0.6.0 Jan 16, 2025
@felbinger felbinger changed the title python312Packages.diode-netbox-plugin: init at 0.6.0 python312Packages.netbox-diode-plugin: init at 0.6.0 Jan 16, 2025
@felbinger felbinger force-pushed the netbox-diode-plugin branch 2 times, most recently from 0035b23 to 7dce738 Compare January 16, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant