Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafanaPlugins.victoriametrics-logs-datasource: init at 0.14.3 #376400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wlcx
Copy link
Contributor

@wlcx wlcx commented Jan 24, 2025

Add the victorialogs grafana datasource plugin

This plugin doesn't exist on grafana's hosted plugin site, so instead we fetch the zip from victoriametrics' github.
Ideally I suppose it should be built from source, but this seemed like a pragmatic middle ground.

Things done

Tested against a 24.11 grafana install. Note that you need to add the plugin to services.grafana.settings.plugins.allow_loading_unsigned_plugins

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 24, 2025
@Shawn8901
Copy link
Contributor

VictoriaMetrics/victorialogs-datasource#214

looks like that there will be finally a signed version if i understand the PR correctly (not yet visible on the market)

I was waiting for similar for the metrics datasource.

@wlcx
Copy link
Contributor Author

wlcx commented Jan 24, 2025

3 hours ago

Wow - total coincidence that I happened to be packaging this. Ok, I'll mark this as draft and will update when it's available via the marketplace

@wlcx wlcx changed the title grafanaPlugins.victoriametrics-logs-datasource: init at 0.13.4 draft: grafanaPlugins.victoriametrics-logs-datasource: init at 0.13.4 Jan 25, 2025
@wlcx wlcx marked this pull request as draft January 25, 2025 23:58
@wlcx wlcx changed the title draft: grafanaPlugins.victoriametrics-logs-datasource: init at 0.13.4 grafanaPlugins.victoriametrics-logs-datasource: init at 0.13.4 Jan 25, 2025
@wlcx wlcx closed this Jan 29, 2025
@wlcx wlcx reopened this Jan 29, 2025
@Shawn8901
Copy link
Contributor

Shawn8901 commented Jan 30, 2025

Fyi https://grafana.com/grafana/plugins/victoriametrics-logs-datasource/

Logs data source has arrived at market place

@wlcx wlcx force-pushed the init-grafana-victoriametrics-plugin branch from 638fda9 to f05f29d Compare January 30, 2025 16:42
@wlcx wlcx marked this pull request as ready for review January 30, 2025 16:50
@wlcx wlcx changed the title grafanaPlugins.victoriametrics-logs-datasource: init at 0.13.4 grafanaPlugins.victoriametrics-logs-datasource: init at 0.14.3 Jan 30, 2025
@wlcx wlcx force-pushed the init-grafana-victoriametrics-plugin branch from f05f29d to 3836916 Compare January 30, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants