Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/wireless: fix indentation of extraConfig #377482

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

wrvsrx
Copy link
Contributor

@wrvsrx wrvsrx commented Jan 28, 2025

fix indentation of extraConfig

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 28, 2025
@wrvsrx wrvsrx force-pushed the fix-wireless-indent branch from 73c4650 to 09fc5e9 Compare January 28, 2025 04:11
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 28, 2025
@rnhmjoj rnhmjoj self-assigned this Jan 28, 2025
@wrvsrx wrvsrx force-pushed the fix-wireless-indent branch from 09fc5e9 to fbf6812 Compare January 29, 2025 08:15
@wrvsrx wrvsrx requested a review from jian-lin January 29, 2025 08:15
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nixosTests.wpa_supplicant.basic:

--- before	2025-01-29 13:55:29.681629009 +0100
+++ after	2025-01-29 13:55:30.323630847 +0100
@@ -3,9 +3,8 @@
   key_mgmt=WPA-PSK
   psk="password"
   scan_ssid=1
-phase1="peaplabel=0"
-phase2="auth=MSCHAPV2"
-
+  phase1="peaplabel=0"
+  phase2="auth=MSCHAPV2"
 }
 
 ctrl_interface=/run/wpa_supplicant

@rnhmjoj rnhmjoj merged commit 2e4d19a into NixOS:master Jan 29, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants