python312Packages.llama-cpp-python: fix linux build #377484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
|
|
Thank you ! |
kirillrdy
reviewed
Jan 28, 2025
Their cmake files were attempting to build with -mcpu=native+no<...> which fails for gcc. Actually, we should never build for native anyway (which is the raison d'etre for NIX_ENFORCE_NO_NATIVE). Thankfully, the package provides a variable to disable native optimizations.
booxter
force-pushed
the
llama-cpp-python-linux-fix
branch
from
e4d317b to
158aa70
Compare
booxter
force-pushed
the
llama-cpp-python-linux-fix
branch
from
158aa70 to
7494270
Compare
|
@kirillrdy I took the liberty and added myself as maintainer. Let me know if there are any concerns with this. |
github-actions
bot
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
kirillrdy
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 377484
aarch64-linux
✅ 8 packages built:
- python312Packages.llama-cpp-python
- python312Packages.llama-cpp-python.dist
- python312Packages.llm-gguf
- python312Packages.llm-gguf.dist
- python313Packages.llama-cpp-python
- python313Packages.llama-cpp-python.dist
- python313Packages.llm-gguf
- python313Packages.llm-gguf.dist
@booxter welcome !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Their cmake files were attempting to build with -mcpu=native+no<...>
which fails for gcc. Actually, we should never build for native anyway
(which is the raison d'etre for NIX_ENFORCE_NO_NATIVE).
Thankfully, the package provides a variable to disable native
optimizations.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.