qownnotes: 25.1.5 -> 25.1.6 #377623
Merged
qownnotes: 25.1.5 -> 25.1.6 #377623
+34
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liberodark
force-pushed
the
qownnotes
branch
2 times, most recently
from
4074176 to
6d25afc
Compare
|
pbek
approved these changes
Jan 28, 2025
matthiasbeyer
requested changes
Jan 29, 2025
There was a problem hiding this comment.
There are several changes in here:
- Version update
- Rewriting to use the
finalAttrspattern instead of alet ... in - Change of the
metaattribute to not use thewith lib;pattern - Adding of the update script
Please split your commit into several commits, each doing one change at a time.
Normally I wouldn't mind a bit of change next to a version update, but this is simply too much, sorry.
Either way, thanks in advance for your effort!
matthiasbeyer
approved these changes
Jan 29, 2025
|
I hope this PR gets merged in the next few hours so I can test it with a new release. 😁 |
|
Not sure whether we should wait for the tests... 🤔 |
|
I'm running the commit before the commit split on 3 machines (x86_64). ️But I don't know about darwin. 🤷🏻 |
|
|
Logs for darwin: |
|
Thank you for the test! I don't think the end2end tests are working on darwin, they depend on X11. |
|
Lets do it |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-377623-to-release-24.11 origin/release-24.11
cd .worktree/backport-377623-to-release-24.11
git switch --create backport-377623-to-release-24.11
git cherry-pick -x 47082f6caae6176d8b486fcb30c7a0adc6f91e90 2db0ef3a8da472a69341aecc7a2daf241b4c414b 54ddab9dff910352aee24d2116279169aa48de43 3b92f76bc53659705dcd2e94f009a696713d5011 |
|
As this is a minor update, I guess we also want to backport this. I know that it includes a few patches that refactor the package, but I think its worth it... |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-377623-to-release-24.11 origin/release-24.11
cd .worktree/backport-377623-to-release-24.11
git switch --create backport-377623-to-release-24.11
git cherry-pick -x 47082f6caae6176d8b486fcb30c7a0adc6f91e90 2db0ef3a8da472a69341aecc7a2daf241b4c414b 54ddab9dff910352aee24d2116279169aa48de43 3b92f76bc53659705dcd2e94f009a696713d5011 |
|
Hm, is there a bot for GitHub to automatically create Pull Requests or something instead of manually calling |
Yes there is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix : #377621
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.