Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.langchain-ollama: fix updateScript eval #377693

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jan 29, 2025

Without the change the update script fails as:

error:

   error: function 'anonymous lambda' called with unexpected argument 'skipBulkUpdate'
   at pkgs/by-name/ni/nix-update/nix-update-script.nix:6:1:
        5|
        6| {
         | ^
        7|   attrPath ? null,

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sorry, something went wrong.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 29, 2025
@mweinelt
Copy link
Member

mweinelt commented Jan 29, 2025

Into staging-next, please.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Without the change the update script fails as:

    error:

       error: function 'anonymous lambda' called with unexpected argument 'skipBulkUpdate'
       at pkgs/by-name/ni/nix-update/nix-update-script.nix:6:1:
            5|
            6| {
             | ^
            7|   attrPath ? null,
@trofi trofi force-pushed the python3Packages.langchain-ollama-fix-updatecript branch from 1f48acf to eabb90e Compare January 29, 2025 21:44
@trofi trofi changed the base branch from staging to staging-next January 29, 2025 21:45
@trofi
Copy link
Contributor Author

trofi commented Jan 29, 2025

Redirected to staging-next.

@mweinelt mweinelt merged commit 34e6ffa into NixOS:staging-next Jan 29, 2025
31 of 35 checks passed
@trofi trofi deleted the python3Packages.langchain-ollama-fix-updatecript branch January 29, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants