Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofi-wayland-unwrapped: 1.7.7+wayland1 -> 1.7.8+wayland1 #377919

Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/lbonn/rofi/releases.

meta.description for rofi-wayland-unwrapped is: Window switcher, run dialog and dmenu replacement for Wayland

meta.homepage for rofi-wayland-unwrapped is: https://github.com/lbonn/rofi

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.7.8+wayland1 with grep in /nix/store/66q5cdv9wnydfb30yrmsgv5snvlvaya9-rofi-wayland-unwrapped-1.7.8+wayland1
  • found 1.7.8+wayland1 in filename of file in /nix/store/66q5cdv9wnydfb30yrmsgv5snvlvaya9-rofi-wayland-unwrapped-1.7.8+wayland1

Rebuild report (if merged into master) (click to expand)
5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath

rofi-emoji-wayland
rofi-pass-wayland
rofi-wayland
rofi-wayland-unwrapped
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/66q5cdv9wnydfb30yrmsgv5snvlvaya9-rofi-wayland-unwrapped-1.7.8+wayland1 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A rofi-wayland-unwrapped https://github.com/r-ryantm/nixpkgs/archive/2a2d6bbc34d1fb8870d050f944bceadc15f4c1cd.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/2a2d6bbc34d1fb8870d050f944bceadc15f4c1cd#rofi-wayland-unwrapped

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/66q5cdv9wnydfb30yrmsgv5snvlvaya9-rofi-wayland-unwrapped-1.7.8+wayland1
ls -la /nix/store/66q5cdv9wnydfb30yrmsgv5snvlvaya9-rofi-wayland-unwrapped-1.7.8+wayland1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 4 packages built:
  • rofi-emoji-wayland
  • rofi-pass-wayland
  • rofi-wayland
  • rofi-wayland-unwrapped

Maintainer pings

cc @bew for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 30, 2025
@nix-owners nix-owners bot requested a review from bew January 30, 2025 08:30
@bew
Copy link
Contributor

bew commented Feb 1, 2025

The change looks good, but I don't use Wayland, could someone using it on wayland can test this and report back?

@Nobody-alias-N
Copy link
Contributor

It works for me and I have not seen any new bugs yet :)
I think you should merge it, if I find something really bad max we can revert it.

@Nobody-alias-N
Copy link
Contributor

I don't know if you have used this before,
or if you even need it,
but I found this seemingly really useful tool: https://github.com/NixOS/nixpkgs-merge-bot
in #378214 so I thought I should share it :)

@bew
Copy link
Contributor

bew commented Feb 3, 2025

I don't know if you have used this before, or if you even need it, but I found this seemingly really useful tool: NixOS/nixpkgs-merge-bot in #378214 so I thought I should share it :)

Yes I know about it ;) But it doesn't work for packages that are not in pkgs/by-name/ hierarchy.

@Nobody-alias-N
Copy link
Contributor

Sorry, I forgot to check the path 😅
Could it be moved in another pr to pkgs/by-name/ro/
or is there a reason why it should not?

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 4, 2025
@donovanglover donovanglover merged commit 662602f into NixOS:master Feb 5, 2025
27 of 29 checks passed
@r-ryantm r-ryantm deleted the auto-update/rofi-wayland-unwrapped branch February 6, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants