llvmPackages: git -> 21.0.0, init 20.1.0-rc1 #378713
Conversation
github-actions
bot
added
the
6.topic: llvm/clang
RossComputerGuy
force-pushed
the
feat/llvm-20
branch
2 times, most recently
from
addb836 to
6465f4f
Compare
|
@ofborg build llvmPackages_20.clang |
RossComputerGuy
force-pushed
the
feat/llvm-20
branch
from
4d93245 to
1bb7b9b
Compare
|
|
RossComputerGuy
force-pushed
the
feat/llvm-20
branch
from
1bb7b9b to
8690a36
Compare
|
@ofborg build llvmPackages_20.clang |
RossComputerGuy
force-pushed
the
feat/llvm-20
branch
2 times, most recently
from
1377331 to
5fed4f0
Compare
nix-owners
bot
requested review from
Ericson2314,
dtzWill,
rrbutani,
lovek323,
alyssais and
sternenseemann
and removed request for
sternenseemann
There was a problem hiding this comment.
Wonderful, thank you! ^_^
Maybe it would make sense to include the fix for #363449 (comment) in here as well?
| builtins.filter | ||
| # Crude method to drop polly patches if present, they're not needed for tblgen. | ||
| (p: (!lib.hasInfix "-polly" p)) | ||
| tools.libllvm.patches; |
There was a problem hiding this comment.
What changed here? Did it just get reformatted? If so, can that please be a separate commit so this is easier to review?
There was a problem hiding this comment.
Yes, it was caused by formatting.
There was a problem hiding this comment.
This has been split out.
|
LGTM, see llvm/llvm-project#125922 which fixes the libcxx build on aarch64 (and therefore pkgsLLVM builds with llvmPackages_git). |
|
Cool, I'll rework this PR with your's and @alyssais's changes tonight after work. |
|
LGTM -- emscripten can be successfully bumped to version 4.0 once this lands. |
RossComputerGuy
force-pushed
the
feat/llvm-20
branch
2 times, most recently
from
2e4c9ee to
7588d80
Compare
RossComputerGuy
force-pushed
the
feat/llvm-20
branch
from
7588d80 to
691e2fc
Compare
|
Ok, @peterwaller-arm's patch is in |
Bumped it out of git so this is done. |
| @@ -1595,7 +1595,7 @@ mapAliases { | |||
| openbsdCross = openbsd; # Added 2024-09-06 | |||
|
|
|||
| # LLVM packages for (integration) testing that should not be used inside Nixpkgs: | |||
| llvmPackages_latest = llvmPackages_19; | |||
| llvmPackages_latest = llvmPackages_20; | |||
There was a problem hiding this comment.
We've never set this to a release candidate before, as far as I know. I think this should wait until release.
Things done
Bumps git to 21, inits 20.1.0-rc1 from git. Just needs some patches rebased.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.