nixos-generate-config: add --flake option #379750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
the
2.status: merge conflict
|
Seems like this needs rebasing on a recent commit first? |
pinpox
force-pushed
the
nixos-generate-config-flake
branch
from
0f238de to
481b89f
Compare
ofborg
bot
removed
the
2.status: merge conflict
pinpox
force-pushed
the
nixos-generate-config-flake
branch
3 times, most recently
from
7ed3895 to
3b816db
Compare
pinpox
force-pushed
the
nixos-generate-config-flake
branch
4 times, most recently
from
ccd7db5 to
614c5ca
Compare
pinpox
force-pushed
the
nixos-generate-config-flake
branch
from
614c5ca to
b91d914
Compare
|
@eclairevoyant You are right, it is rebased now. |
eclairevoyant
suggested changes
Feb 6, 2025
| outputs = inputs\@{ self, nixpkgs, ... }: { | ||
| # NOTE: 'nixos' is the default hostname set by the installer | ||
| nixosConfigurations.nixos = nixpkgs.lib.nixosSystem { | ||
| system = "${pkgs.stdenv.hostPlatform.system}"; |
There was a problem hiding this comment.
Suggested change
| system = "${pkgs.stdenv.hostPlatform.system}"; |
nixpkgs.hostPlatform should already get set in hardware-configuration.nix, and passing system to lib.nixosSystem is deprecated:
Lines 52 to 54 in 121c18d
| { | ||
| inputs = { | ||
|
|
||
| # NOTE: Replace "nixos-${config.system.nixos.release}" on new releases |
There was a problem hiding this comment.
Suggested change
| # NOTE: Replace "nixos-${config.system.nixos.release}" on new releases | |
| # NOTE: Replace "nixos-${config.system.nixos.release}" (after reading the release notes) on new releases |
Comment on lines
+207
to
+209
| This is an internal option. No backward compatibility is guaranteed. | ||
| Use at your own risk! | ||
|
|
There was a problem hiding this comment.
Nit: this is probably superfluous, internal options don't even appear in the docs, so if someone found out about it, they are already looking at the code
eclairevoyant
suggested changes
Feb 6, 2025
Comment on lines
+68
to
+69
| # NOTE: 'nixos' is the default hostname set by the installer | ||
| nixosConfigurations.nixos = nixpkgs.lib.nixosSystem { |
There was a problem hiding this comment.
Suggested change
| # NOTE: 'nixos' is the default hostname set by the installer | |
| nixosConfigurations.nixos = nixpkgs.lib.nixosSystem { | |
| # NOTE: '${options.networking.hostName.default}' is the default hostname | |
| nixosConfigurations.${options.networking.hostName.default} = nixpkgs.lib.nixosSystem { |
a-kenji
approved these changes
Feb 8, 2025
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--flakeoption tonixos-generate-configwhich optionally also generates aflake.nixfile alongside ofconfiguration.nixandhardware-configuration.nix. It gives people stumbling across tutorials that explain flake-based setups an easy starting point with a simple flake, without impacting existing or non-flake configusrations.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.