nixos/version: validate system.stateVersion #379754
Open
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
|
Am I supposed to edit |
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
|
NotAShelf
reviewed
Feb 6, 2025
| ${config.system.stateVersion} is an invalid value for `system.stateVersion`; it must be in the format `YY.MM`, which corresponds to a prior release of NixOS. | ||
| If you want to switch releases or switch to unstable, you should change your channel and/or flake input URLs only. | ||
| *DO NOT* touch the `system.stateVersion` option, as it will not help you upgrade. |
There was a problem hiding this comment.
Nit but since backticks aren't used for anything in terminals, I would like to suggest using ' ' instead. Looks a little more coherent imho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New users do not understand the purpose of
system.stateVersionand often set it to invalid values when switching channels.Since they don't read the comment nor the option description, add a sterner assertion to warn them about clearly invalid values like "unstable".
This prevents issues like https://discourse.nixos.org/t/how-to-exclude-xterm-from-nixos/59887.
This only validates that the stateVersion string matches the (2 digits).(2 digits) format, and eschews additional restrictions.
If one needs a "maximal" or "minimal" value for testing purposes, values like "00.00" and "99.99" are still permissible.
#351158 is a similar but ultimately different PR.
I prefer my approach as it
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.