Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/postgresql/citus: fix syscall filter and add test #379769

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

jflanglois
Copy link
Contributor

This fixes the citus extension for postgresql. Without this, the database will crash on start because the extension uses getpriority and setpriority syscalls. The ~@privileged @resources filter breaks those calls. This also adds automated tests for citus.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 6, 2025
@jflanglois jflanglois changed the title nixos/postgresql: fix syscall filter and add test nixos/postgresql/citus: fix syscall filter and add test Feb 6, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 6, 2025
@github-actions github-actions bot added 6.topic: python 6.topic: emacs Text editor 6.topic: rust 6.topic: golang 6.topic: lua 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: documentation This PR adds or changes documentation labels Feb 6, 2025
@jflanglois jflanglois changed the base branch from master to staging February 6, 2025 23:12
@github-actions github-actions bot removed 6.topic: python 6.topic: emacs Text editor 6.topic: rust 6.topic: golang 6.topic: lua 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related labels Feb 6, 2025
@jflanglois
Copy link
Contributor Author

Build failure looks related to rustc, so I assume this is due to the state of staging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, in #355010 we didn't add a whole new test on purpose - because this won't scale for many extensions. We can't add a new VM test for each of them. But I think we also can't test them together, otherwise the granted exceptions here might overlay each other.

At the same time - we should really test this. So we need a VM test.

I don't really have a solution, but I do think that a VM test for citus is generally a good idea, especially if we consider that this test could be extended to test multiple machines setting up a citus cluster in the future.

TLDR: I'm OK with adding another test here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right I agree with a multi-node test, but would rather do that on top of master when staging is merged

Copy link
Contributor Author

@jflanglois jflanglois Feb 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also makes me think: I wonder if the hardening should be made more configurable in the module? It seems like extensions could easily hit a blocked syscall after an update and this was difficult to debug for me because there were no logs—I only looked at hardening options because postgresql started fine when run manually.

nixos/tests/postgresql/citus.nix Outdated Show resolved Hide resolved
@wolfgangwalther
Copy link
Contributor

Build failure looks related to rustc, so I assume this is due to the state of staging.

I am building on staging with very low resources allocated - so this might take a while. Will still look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants