Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epson_201207w: 1.0.0 -> 1.0.1 #379773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafaelrc7
Copy link
Member

@rafaelrc7 rafaelrc7 commented Feb 6, 2025

This package was outdated and failing to build. So I updated it and now it works again.

The download links have changed and seem to have random parts. Thus I remove the version variable from it, since in future updates the link will have to be fetched manually.

The filter version is also different from the package version, so a separate variable was set to reference it.

The filter licence was also set to the more specific lgpl21Plus.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The download links have changed and seem to have random parts. Thus I
remove the version variable from it, since in future updates the link
will have to be fetched manually.

The filter version is also different from the package version, so a
separate variable was set to reference it.

The filter licence was also set to the more specific lgpl21Plus.
@rafaelrc7
Copy link
Member Author

CC. @romildo

Tagging you as you are the package maintainer

@rafaelrc7 rafaelrc7 requested a review from romildo February 8, 2025 17:27
@rafaelrc7 rafaelrc7 added the 8.has: package (update) This PR updates a package to a newer version label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant