Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "python3Packages.qtile(-extras)" upgrades #380524

Merged
merged 3 commits into from
Feb 9, 2025

Conversation

Lassulus
Copy link
Member

@Lassulus Lassulus commented Feb 9, 2025

qtile was updated but this seems to break xwayland support if running with the wayland backend.
The real update should be: #371737

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Lassulus Lassulus changed the title Revert "python3Packages.qtile: dbus-next -> dbus-fast" Revert "python3Packages.qtile(-extras)" upgrades Feb 9, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 9, 2025
@Lassulus
Copy link
Member Author

Lassulus commented Feb 9, 2025

related to #375144

@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380524


x86_64-linux

❌ 2 packages failed to build:
  • python313Packages.qtile-extras
  • python313Packages.qtile-extras.dist
✅ 10 packages built:
  • python312Packages.qtile
  • python312Packages.qtile-bonsai
  • python312Packages.qtile-bonsai.dist
  • python312Packages.qtile-extras
  • python312Packages.qtile-extras.dist
  • python312Packages.qtile.dist
  • python313Packages.qtile
  • python313Packages.qtile-bonsai
  • python313Packages.qtile-bonsai.dist
  • python313Packages.qtile.dist

@philiptaron
Copy link
Contributor

The two tests that fail are flaky -- I tried to re-build python313Packages.qtile-extras and it succeeded.

@Lassulus Lassulus merged commit 90d5018 into NixOS:master Feb 9, 2025
34 of 35 checks passed
@arjan-s
Copy link
Contributor

arjan-s commented Feb 10, 2025

Thank you for fixing it so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants