Pb cli and capture initialization #54349
Conversation
GrahamcOfBorg
added
8.has: package (new)
| meta = with stdenv.lib; { | ||
| description = "A no bullshit screen capture tool"; | ||
| homepage = "https://github.com/buhman/capture"; | ||
| maintainers = [ maintainers.ar1a ]; |
There was a problem hiding this comment.
Needs a license https://search.nix.gsc.io/?q=license%20%3D&i=nope&files=&repos= (same with the other package.)
There was a problem hiding this comment.
neither packages have licenses, and as far as i could tell the default license is unfree - which would be accurate here i think.
There was a problem hiding this comment.
Hmm... I'm not sure we can really package software which isn't licensed... Maybe you're right, though. Can you open issues on those repos and ask them to apply a license?
There was a problem hiding this comment.
ptpb/pb_cli#12 buhman/capture#6
I thought we could package unfree software, for example discord or spotify
There was a problem hiding this comment.
For sure we can, but they have a license saying they're unfree... but unlicensed is much less clear about rights, right?
There was a problem hiding this comment.
im not sure, i would argue that they just forgot to license the code especially because its advertised https://ptpb.pw/#shell-functions here but obviously that wouldn't really hold up. is there anyone you can ping who knows more about this stuff?
There was a problem hiding this comment.
I thought the GitHub TOS changed to grant some basic licenses, but it turns out to be much more minimal than I expected:
If you publish your source code in a public repository on GitHub, according to the Terms of Service, other GitHub users have the right to view and fork your repository within the GitHub site.
I don't know ... I think there isn't a strict policy around requiring a license for Nixpkgs inclusion, but it sure seems there should be one ;)
I won't block on this problem.
There was a problem hiding this comment.
should i explicitly set it to unfree for the meantime then or just leave it omitted
| patchShebangs $out/bin/capture | ||
| wrapProgram $out/bin/capture \ | ||
| --prefix PATH : '${stdenv.lib.makeBinPath [ slop ffmpeg ]}' | ||
| ''; |
There was a problem hiding this comment.
Indent the text between '' quotes two spaces (same on the other package).
There was a problem hiding this comment.
Let's do the patching and wrapping before the install call, ideally within the buildPhase.
|
@GrahamcOfBorg build pb_cli capture |
|
@GrahamcOfBorg build pb_cli capture |
|
Dang, forgot for ofborg to finish. |
|
ptpb/pb#246 rip |
Motivation for this change
pb is a fantastic pastebin service with a nice client, and it optionally depends on capture, which is a fantastic screen cap tool that uses ffmpeg. I use both of these at least every week and thought it'd be a nice addition.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)