-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI host application #245
base: master
Are you sure you want to change the base?
GUI host application #245
Conversation
I checked out your app and would like to thank you for your efforts so far, as it seems like a rather neat admin panel. That being said, I'm not sure it's a perfect fit to include in the main repo, due to its broad functionality and reliance on several third-party frameworks and applications. As is, I don't think it's simple enough to use for the people who would benefit most from it, as the installation alone is arguably even more complex than running Melia. Both a hypothetical admin panel as well as the proposed host application (#209) would ideally be usable by default and not require any additional steps to run. At most, they should require copying the folder from the optional web directory. Furthermore, you're shaping this app into a one-stop shop for managing Melia, which, to be clear, is a great thing to have. But it feels too large and broad for my linking if that makes sense. I believe it's essential for the core application to maintain a certain level of simplicity and focus, whereas the creation and maintenance of your admin panel is a rather large undertaking in itself, not to mention that it adds almost 10 MB to the repo, which is twice as large as the entire source code. As such, I believe it would be better suited to exist as a separate project that users may download and add to their installation at their discretion, instead of shipping all versions of Melia with it. I will leave this PR open for the moment, because there's some valuable code to be found here, like the API additions we might want to include in the core, for applications such as yours to utilize, but I don't think we'll merge the entire app. |
Tecnologies/Libraries envolved: