-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chain-specific Block, LocalBlock, and BlockReceipt types #741
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/multichain #741 +/- ##
==================================================
Coverage ? 54.38%
==================================================
Files ? 243
Lines ? 28237
Branches ? 28237
==================================================
Hits ? 15358
Misses ? 11952
Partials ? 927 ☔ View full report in Codecov by Sentry. |
The benchmark CI job was failing. I've been investigating it and learned the following (skipping debugging steps for brevity):
|
With the fix for the benchmarks, this PR now only has issues with the Mac CI. I'll merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Resolves #735
The primary change in this PR is the addition of chain-specific
Block
,LocalBlock
, andBlockReceipt
types; along with supporting types, such as aBlockBuilder
andBlockReceiptFactory
.In addition, for parts of the codebase that I touched (or required it), I made the following changes:
ChainSpecT
generics and instead replace them with more granular genericsFollow-up
L1BlockInfo
in RPC receipts for Optimism hardforks #742