Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UIs for configuring voltage for GPIO Ports 1,2 and 7 for nRF54H20 DK (PCA10175) #151

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Remove UIs for configuring voltage for GPIO Ports 1,2 and 7 for nRF54H20 DK (PCA10175) #151

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e72dcea
Future definition
KievDevel Jan 22, 2025
7d41f42
Cleanup
KievDevel Jan 22, 2025
ddae7f9
Upd version
KievDevel Jan 22, 2025
3063860
update port back to port 2
KievDevel Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions src/common/boards/nrf_PCA10175_1.0.0_54H20.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
{
"board": {
"boardVersion": "PCA10175",
"boardRevision": "1.0.0",
"boardName": "nRF54H20 DK v1.0.0"
Comment on lines +4 to +5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.0.0 is an assumption.

Not updating current 0.7.0 definition file https://github.com/NordicSemiconductor/pc-nrfconnect-board-configurator/blob/main/src/common/boards/nrf_PCA10175_0.7.0_54H20.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD. New config should be for all devices

},
"pins": [
{
"type": "vcom",
"id": "vcom0",
"name": "VCOM0",
"enable": {
"pin": 42
},
"hwfc": {
"pin": 20
}
},
{
"type": "vcom",
"id": "vcom1",
"name": "VCOM1",
"enable": {
"pin": 22
},
"hwfc": {
"pin": 23
}
},
{
"type": "switch",
"id": "swd3-control",
"title": "Software Debugger (SWD)",
"label": "Disable to use an external debugger on the target chip.",
"tooltip": "When enabled, the SWD is connected and the IMCU is acting as the debugger. When disabled, the SWD is disconnected and you can use an external debugger connected to the Debug In header.",
"enable": {
"pin": 6
}
},
{
"type": "switch",
"id": "led-pwr-ctrl",
"title": "LED Power",
"label": "Disable LEDs to use the GPIOs for other purposes.",
"tooltip": "The LEDs are enabled by providing 5 V to LED0-LED3.",
"enable": {
"pin": 45
}
},
{
"type": "switch",
"id": "ldos-flash-dis",
"title": "External Memory",
"label": "Enable power to the external flash memory.",
"tooltip": "Enable external flash by powering the rails VCCQ_1V8 and VCC_1V8.",
"enable": {
"pin": 47,
"invert": true
}
}
],
"pmicPorts": [
{
"type": "voltage",
"port": 1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was port: 2, but I assume this is just an index property?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port number refers to actual port in the PMIC, and is not arbitrary. Changing port here will alter another output on the PMIC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says to remove controls for ports 1,2 and 7.
As for ports numbers we have only 1-4 range, I've removed controls based on their descriptions as that might be what user see. Is that correct?

For the port property will return 2 number

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GPIO ports are "groups" of electronic pins on the target microcontroller (54H20) itself. The port number here is the output on the power management chip (supplying different voltages to the 54H20 which is, in turn, used to power the GPIO ports).

To find out which PMIC port we need to hide, we need to look into the HW design of the DK:
https://nordicsemi.atlassian.net/wiki/spaces/APPS/pages/67295432/nRF5340+Board+Controller+-+1.6+nRF5340+Pinout#nRF54H20-DK

image

From the table, it looks like only port 2 (GPIO port 9) should be configurable, leaving the three other IO ports out.

This means we should have only port 2 in the definition file.

"portId": "vdd-p9",
"portLabel": "VDD-p9 (nPM VOUT2)",
"portDescription": "Voltage on the VDD rail of nRF54H20 P9.",
"mVmin": 1800,
"mVmax": 3300
}
],
"defaults": {
"pins": [
{
"pin": 42,
"state": true
},
{
"pin": 20,
"state": true
},
{
"pin": 22,
"state": true
},
{
"pin": 23,
"state": true
},
{
"pin": 6,
"state": true
},
{
"pin": 45,
"state": true
},
{
"pin": 47,
"state": true
}
],
"pmicPorts": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other ports were removed from here as well

{
"port": 1,
"voltage": 1800
}
]
}
}
11 changes: 10 additions & 1 deletion src/features/Configuration/boardDefinitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import nrf54l15v020json from '../../common/boards/nrf_PCA10156_0.2.0.json';
import nrf54l15v030json from '../../common/boards/nrf_PCA10156_0.3.0.json';
import nrf9151v020json from '../../common/boards/nrf_PCA10171_0.2.0_9151.json';
import nrf54h20v070json from '../../common/boards/nrf_PCA10175_0.7.0_54H20.json';
import nrf54h20v100json from '../../common/boards/nrf_PCA10175_1.0.0_54H20.json';

export type BoardDefinition = {
boardControllerConfigDefinition?: BoardControllerConfigDefinition;
Expand All @@ -35,6 +36,8 @@ const typednrf54l15v030json =
const typednrf54h20json = nrf54h20pdk080json as BoardControllerConfigDefinition;
const typednrf54h20v070json =
nrf54h20v070json as BoardControllerConfigDefinition;
const typednrf54h20v100json =
nrf54h20v100json as BoardControllerConfigDefinition;
const typednrf9151v020json = nrf9151v020json as BoardControllerConfigDefinition;

export function getBoardDefinition(
Expand Down Expand Up @@ -86,7 +89,13 @@ export function getBoardDefinition(

case 'PCA10175':
// nRF54H20
return { boardControllerConfigDefinition: typednrf54h20v070json };
if (boardRevision === '0.7.0') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there might be more versions than 0.7.0. We should have a look around to see which DPKs are available. (Otherwise the new file will be default for all otheer H20s (which might be fine, altogether)

Copy link
Contributor Author

@KievDevel KievDevel Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Thought that is something to check closer to the date when merge is required
.
Same for the version as it is totally guessed now

return {
boardControllerConfigDefinition: typednrf54h20v070json,
};
}

return { boardControllerConfigDefinition: typednrf54h20v100json };

default:
return { controlFlag: { unrecognizedBoard: true } };
Expand Down
Loading