Add tooltip for flowcontrol checkbox, updated version and changelog

NordicSemiconductor · Oct 6, 2020 · e6205f8 · e6205f8
1 parent 2cf4ed8
commit e6205f8
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 10 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,3 +1,7 @@
+## Version 1.1.7
+### Updates
+- Added flow control checkbox (@jaredwolff) #43
+
 ## Version 1.1.6
 ### Fixes
 - Fix device filter for Thingy:91 #40

diff --git a/lib/components/Settings.jsx b/lib/components/Settings.jsx
@@ -49,14 +49,20 @@ import Slider from 'react-rangeslider';
 import 'react-rangeslider/lib/index.css';
 
 const popoverAutoRequests = (
-    <Popover id="tip-location-api" className="tip location-api">
+    <Popover id="tip-autoreq" className="tip autoreq">
         <p>
             The application automatically sends AT commands when connecting to the
             device to query the state of the modem and to subscribe to notifications.
         </p>
     </Popover>
 );
 
+const popoverFlowControl = (
+    <Popover id="tip-flowcontrol" className="tip flowcontrol">
+        <p>You must reopen the device to take effect.</p>
+    </Popover>
+);
+
 const popoverToken = (
     <Popover id="tip-location-api" className="tip location-api">
         <p>
@@ -142,14 +148,16 @@ class Settings extends React.Component {
                                     label="Terminal auto scroll"
                                 />
                             </Form.Group>
-                            <Form.Group controlId="flowControlCheck">
-                                <Form.Check
-                                    type="checkbox"
-                                    onChange={e => flowControlToggled(e.target.checked)}
-                                    checked={flowControl}
-                                    label="Flow control"
-                                />
-                            </Form.Group>
+                            <OverlayTrigger {...overlayProps} overlay={popoverFlowControl}>
+                                <Form.Group controlId="flowControlCheck">
+                                    <Form.Check
+                                        type="checkbox"
+                                        onChange={e => flowControlToggled(e.target.checked)}
+                                        checked={flowControl}
+                                        label="Flow control"
+                                    />
+                                </Form.Group>
+                            </OverlayTrigger>
                             Periodic signal quality request {signalQualityInterval > 0 ? `${signalQualityInterval}s` : 'off'}
                             <div className="slider-container">
                                 <span>off</span>

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "pc-nrfconnect-linkmonitor",
-  "version": "1.1.6",
+  "version": "1.1.7",
   "description": "LTE Link Monitor",
   "displayName": "LTE Link Monitor",
   "repository": {