Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2244 - Finance Fixes - Deny own reimbursement request #3225

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

staysgt
Copy link
Contributor

@staysgt staysgt commented Feb 17, 2025

Changes

User can now deny their own reimbursements requests, regardless of whether they are on the finance team. Updated both backend and frontend.

Test Cases

  • Regular deny reimbursement request still works
  • Non finance user can deny their own reimbursement request

Screenshots

Screenshot 2025-02-18 at 10 08 56 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2244

@staysgt staysgt self-assigned this Feb 17, 2025
@staysgt staysgt force-pushed the #2244-Deny-Own-Reimbursement-Request branch from 664b71c to 0d7ccce Compare February 17, 2025 23:50
@kb578432
Copy link
Contributor

Looks good! Do you think you could get a screenshot to show that the deny button appears for users' own reimbursement requests?

@staysgt
Copy link
Contributor Author

staysgt commented Feb 19, 2025

@kb578432 added

@wavehassman wavehassman requested a review from vsp05 February 20, 2025 02:32
Copy link
Contributor

@vsp05 vsp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Sarah! Thank you sm for writing the test as well!

@vsp05 vsp05 requested a review from walker-sean February 20, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finance Fixes - Deny own reimbursement request
3 participants