Theme: add rose-pine
#219
Merged
Theme: add rose-pine
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply added the rose-pine input and added it as a theme.
|
Looks good! I'll review it in a bit, but probably a quick merge.
Did you build |
NotAShelf
approved these changes
Feb 13, 2024
|
|
||
| styles = { | ||
| bold = false, | ||
| italic = false, -- I would like to add more options for this |
There was a problem hiding this comment.
you're more than welcome to do so! I can't think of a backwards-compatible way of, but we can introduce a freeform settings attribute to be shared scross modules so that they are able to freely define their own settings :)
|
Theme name properly visible in the latest doc build, merging. Thanks! |
bloxx12
pushed a commit
to bloxx12/nvf
that referenced
this pull request
Sep 29, 2024
Theme: add `rose-pine`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added rose-pine as a theme.
I don't think I missed anything, but please tell me if I did.
Type of change
Checklist
Screenshots & Logs
(the git tree was only dirty because I was testing the theme)
I couldn't figure out how to get the docs to update the styles list, but the themes work.