Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim/init: set basic options via vim.options #455

Merged
merged 4 commits into from
Dec 1, 2024
Merged

Conversation

NotAShelf
Copy link
Owner

@NotAShelf NotAShelf commented Nov 10, 2024

Less DAGs, more customizability.

Moves interpolated basic vim options into vim.options with a backwards compatible interface. I'm fully intending to deprecate all of the options before merge.

Sanity Checking

  • I have updated the changelog as per my changes.
  • I have tested, and self-reviewed my code.
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt).
    • My code conforms to the editorconfig configuration of the project.
    • My changes are consistent with the rest of the codebase.
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual.
    • (For breaking changes) I have included a migration guide.
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

Less DAGs, more customizability.
@NotAShelf NotAShelf marked this pull request as ready for review December 1, 2024 06:41
Copy link
Collaborator

@diniamo diniamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a breaking changes entry in the release notes.

I'm also in favor of removing the more complex options.

modules/extra/deprecations.nix Outdated Show resolved Hide resolved
@NotAShelf
Copy link
Owner Author

It is not entirely a breaking change since the side effects have been remedied. All renamed options have an equivalent in the new format, except for shift/tab width.

I'll add an entry for those.

@diniamo
Copy link
Collaborator

diniamo commented Dec 1, 2024

This definitely is a breaking changes, since the renamed options will break the user's configuration if they used to override any of them.

@NotAShelf
Copy link
Owner Author

NotAShelf commented Dec 1, 2024

Moved the deprecation/migration notes to the breaking changes section.

Copy link
Collaborator

@diniamo diniamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@NotAShelf NotAShelf merged commit d17c010 into v0.7 Dec 1, 2024
10 checks passed
@NotAShelf NotAShelf deleted the migrate-opts branch December 1, 2024 15:45
@NotAShelf NotAShelf mentioned this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants