-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neovim/init: set basic options via vim.options
#455
Conversation
6082da3
to
89f68f7
Compare
Less DAGs, more customizability.
a2d1231
to
812064f
Compare
812064f
to
864ee05
Compare
b1867e6
to
8f76da4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a breaking changes entry in the release notes.
I'm also in favor of removing the more complex options.
It is not entirely a breaking change since the side effects have been remedied. All renamed options have an equivalent in the new format, except for shift/tab width. I'll add an entry for those. |
8f76da4
to
11bab69
Compare
This definitely is a breaking changes, since the renamed options will break the user's configuration if they used to override any of them. |
11bab69
to
9869161
Compare
Moved the deprecation/migration notes to the breaking changes section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Less DAGs, more customizability.
Moves interpolated basic vim options into
vim.options
with a backwards compatible interface. I'm fully intending to deprecate all of the options before merge.Sanity Checking
nix fmt
)..#nix
(default package).#maximal
.#docs-html
x86_64-linux
aarch64-linux
x86_64-darwin
aarch64-darwin
Add a 👍 reaction to pull requests you find important.