Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filetree/nvim-tree: Open on directory #462

Merged
merged 8 commits into from
Dec 23, 2024

Conversation

DamitusThyYeetus123
Copy link
Contributor

When nvim-tree is enabled, opening nvim with a directory opens nvim-tree in that directory, and cds to the directory.

Sanity Checking

  • I have updated the changelog as per my changes.
  • I have tested, and self-reviewed my code.
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt).
    • My code conforms to the editorconfig configuration of the project.
    • My changes are consistent with the rest of the codebase.
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual.
    • (For breaking changes) I have included a migration guide.
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@NotAShelf
Copy link
Owner

Opening a directory with vim . should already open said directory with nvim-tree. I think this might be related to LazyLoading since we currently have a similar issue with neo-tree.

@diniamo
Copy link
Collaborator

diniamo commented Nov 15, 2024

#446 should fix this too.

@DamitusThyYeetus123
Copy link
Contributor Author

DamitusThyYeetus123 commented Nov 15, 2024

This feature was removed from nvimTree and should be added externally as seen here https://github.com/nvim-tree/nvim-tree.lua/wiki/Open-At-Startup. This PR modifies the nvimTree script used to open on startup to also open for directories, which was not previously enabled.

@diniamo
Copy link
Collaborator

diniamo commented Nov 15, 2024

it's still going to have conflicts with that PR, so you have to at least rebase on it.

@DamitusThyYeetus123
Copy link
Contributor Author

Is that PR not ready for commit yet?

@DamitusThyYeetus123
Copy link
Contributor Author

#446 did not fix, will rebase and fix up now.

@DamitusThyYeetus123
Copy link
Contributor Author

Rebased, no fixes needed

Copy link
Collaborator

@horriblename horriblename left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the unnecessary space

modules/plugins/filetree/nvimtree/config.nix Outdated Show resolved Hide resolved
@horriblename
Copy link
Collaborator

(waiting for CI to finish)

@NotAShelf
Copy link
Owner

CI is failing all around.

@DamitusThyYeetus123
Copy link
Contributor Author

whoops lemme fix up formatting

@NotAShelf NotAShelf changed the base branch from v0.7 to main December 4, 2024 14:48
@NotAShelf NotAShelf merged commit 3a2edd1 into NotAShelf:main Dec 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants