refactor: remove anythingConcatLists #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horriblename
force-pushed
the
refactor-kill-anythingConcatLists
branch
5 times, most recently
from
a11e940 to
da26ea7
Compare
horriblename
force-pushed
the
refactor-kill-anythingConcatLists
branch
from
71779bf to
eb132ee
Compare
diniamo
requested changes
Dec 29, 2024
|
don't see any changes in eval time on my HM config |
diniamo
previously approved these changes
Dec 29, 2024
horriblename
force-pushed
the
refactor-kill-anythingConcatLists
branch
from
110944a to
3c3b08f
Compare
NotAShelf
changed the title
NotAShelf
requested changes
Dec 29, 2024
horriblename
force-pushed
the
refactor-kill-anythingConcatLists
branch
4 times, most recently
from
9899408 to
d14c5e5
Compare
|
Requesting a review from @diniamo for the sake of getting another pair of eyes on this. |
diniamo
requested changes
Jan 1, 2025
horriblename
force-pushed
the
refactor-kill-anythingConcatLists
branch
from
cfbcced to
8df03f9
Compare
diniamo
approved these changes
Jan 1, 2025
the bulk of the build step is moved to modules/wrapper/build
diniamo
force-pushed
the
refactor-kill-anythingConcatLists
branch
from
8df03f9 to
da5bc31
Compare
NotAShelf
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the cursed
anythingConcatListstype used in the HM and nixos modules.TODO: