Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languages/ruby: add ruby support #556

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

tomasguinzburg
Copy link
Contributor

@tomasguinzburg tomasguinzburg commented Jan 13, 2025

Ruby is a pain, but I think some basic support is better than nothing and can be improved on.
At the moment, formatters only work if .rubocop.yml contains no extensions, as most of those are not available through nixpkgs yet.

This is my first nix PR so please be thorough.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@tomasguinzburg tomasguinzburg marked this pull request as ready for review January 13, 2025 14:26
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. A few minor changes for the sake of consistency, and I can merge this.

modules/plugins/languages/ruby.nix Outdated Show resolved Hide resolved
modules/plugins/languages/ruby.nix Outdated Show resolved Hide resolved
configuration.nix Outdated Show resolved Hide resolved
modules/plugins/languages/ruby.nix Outdated Show resolved Hide resolved
@NotAShelf
Copy link
Owner

Merging once CI passes.

@NotAShelf
Copy link
Owner

Alright preview CI is unrelated, thank you for your efforts.

@NotAShelf NotAShelf merged commit 4b90470 into NotAShelf:main Jan 13, 2025
12 of 13 checks passed
@tomasguinzburg tomasguinzburg deleted the feat-languages-ruby branch January 17, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants