Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languages/typst: Add inline preview via typst-concealer #588

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PartyWumpus
Copy link

Adds the typst-concealer plugin for displaying typst inline.

This is marked as draft because I'm not sure about:

  • Do I need to put something in some release notes?
  • Should I add default keybinds? The plugin basically needs them.
  • Should I change the descriptions to better fit the way they're phrased elsewhere? Currently they're just ripped from my code.
  • Should I be explicit about the defaults instead of just null and letting the plugin pick?

@NotAShelf
Copy link
Owner

Do I need to put something in some release notes?

A very quick entry would be nice.

Should I add default keybinds? The plugin basically needs them.

Sure, you can set them as its done in many module. See telescope for an example.

Should I change the descriptions to better fit the way they're phrased elsewhere? Currently they're just ripped from my code.

Option descriptions are usually from plugin documentation in our case. You're free to change them, but I'm not going to ask you to.

Should I be explicit about the defaults instead of just null and letting the plugin pick?

Leaving setupOpts empty means plugin's defaults will be used (if the plugin sets them.) Up to you whether you think some defaults are more... equal than others.

modules/plugins/languages/typst.nix Outdated Show resolved Hide resolved
modules/plugins/languages/typst.nix Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

🚀 Live preview deployed from da48a86

View it here:

Debug Information

Triggered by: PartyWumpus

HEAD at: main

Reruns: 150

github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
@PartyWumpus PartyWumpus marked this pull request as ready for review January 27, 2025 14:56
@PartyWumpus PartyWumpus requested a review from NotAShelf January 27, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants