Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Pooling layers #583

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

hglee98
Copy link
Contributor

@hglee98 hglee98 commented Nov 5, 2024

Description

This PR aims to replace pooling layers into custom Pool blocks.

Closes: N/A

We recommend to link at least one existing issue for PR. Before your create a PR, please check if there is an issue for this change.

Change(s)

  • Add POOL_REGISTRY dict
  • Add Pool class into models.op.custom
  • Replace with custom Pool implementation

Code Formatting

If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

Changelog

If your PR is granted to dev branch, codeowner will add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file including a link to the PR (formatted in markdown) and a link to your github profile.

For example,

- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

Please enable Allow edits and access to secrets by maintainers so that our maintainers can update the CHANGELOG.md.

@illian01 illian01 added the refactoring Changes code or architecture internally without changing the output. label Nov 12, 2024
@hglee98
Copy link
Contributor Author

hglee98 commented Nov 15, 2024

Thank you for the review! I've included your feedback from additional commits!🙇🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Changes code or architecture internally without changing the output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants