Skip to content

Commit

Permalink
Introduce NuGetLocalizationType parameter in YAML to support PLOC tes…
Browse files Browse the repository at this point in the history
…ting (#4857)
  • Loading branch information
donnie-msft authored Oct 21, 2022
1 parent d19da5b commit e89d782
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 1 deletion.
1 change: 1 addition & 0 deletions build/vsts_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,4 @@ extends:
E2EPart1AgentCleanup: ${{parameters.E2EPart1AgentCleanup}}
E2EPart2AgentCleanup: ${{parameters.E2EPart2AgentCleanup}}
ApexAgentCleanup: ${{parameters.ApexAgentCleanup}}
NuGetLocalizationType: Full
1 change: 1 addition & 0 deletions eng/pipelines/official.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,4 @@ extends:
E2EPart1AgentCleanup: ${{parameters.E2EPart1AgentCleanup}}
E2EPart2AgentCleanup: ${{parameters.E2EPart2AgentCleanup}}
ApexAgentCleanup: ${{parameters.ApexAgentCleanup}}
NuGetLocalizationType: Full
8 changes: 8 additions & 0 deletions eng/pipelines/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ parameters:
values:
- delete
- stop
- name: NuGetLocalizationType
displayName: Whether to do production-ready localization (Full), or pseudo-localization, aka PLOC, (Pseudo) for testing.
type: string
default: Full
values:
- Full
- Pseudo

extends:
template: templates/pipeline.yml
Expand All @@ -35,3 +42,4 @@ extends:
E2EPart1AgentCleanup: ${{parameters.E2EPart1AgentCleanup}}
E2EPart2AgentCleanup: ${{parameters.E2EPart2AgentCleanup}}
ApexAgentCleanup: ${{parameters.ApexAgentCleanup}}
NuGetLocalizationType: ${{parameters.NuGetLocalizationType}}
4 changes: 3 additions & 1 deletion eng/pipelines/templates/Build_and_UnitTest.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
parameters:
- name: BuildRTM
type: boolean
- name: NuGetLocalizationType
type: string

steps:
- task: PowerShell@1
Expand Down Expand Up @@ -106,7 +108,7 @@ steps:
inputs:
solution: "build\\loc.proj"
configuration: "$(BuildConfiguration)"
msbuildArguments: "/t:AfterBuild /bl:$(Build.StagingDirectory)\\binlog\\03.Localize.binlog"
msbuildArguments: "/t:AfterBuild /bl:$(Build.StagingDirectory)\\binlog\\03.Localize.binlog /p:LocType=${{parameters.NuGetLocalizationType}}"

- task: MSBuild@1
displayName: "Build NuGet.exe Localized"
Expand Down
9 changes: 9 additions & 0 deletions eng/pipelines/templates/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ parameters:
values:
- delete
- stop
- name: NuGetLocalizationType
displayName: Whether to do production-ready localization (Full), or pseudo-localization, aka PLOC, (Pseudo) for testing.
type: string
default: Full
values:
- Full
- Pseudo

resources:
pipelines:
Expand Down Expand Up @@ -102,6 +109,7 @@ stages:
- template: Build_and_UnitTest.yml
parameters:
BuildRTM: false
NuGetLocalizationType: ${{ parameters.NuGetLocalizationType }}

- stage: Build_For_Publishing
displayName: Build NuGet published to nuget.org
Expand All @@ -122,6 +130,7 @@ stages:
- template: Build_and_UnitTest.yml
parameters:
BuildRTM: true
NuGetLocalizationType: Full

- stage: Source_Build
dependsOn: Initialize
Expand Down

0 comments on commit e89d782

Please sign in to comment.