OutputConsoleLogger supports not forcing focus onto the Error List #6241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Status:No recent activity
microsoft-github-policy-service
bot
removed
the
Status:No recent activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11728
Description
Draft - for an upcoming Quality Week I want to investigate if I can improve 2 things:
When "Clear NuGet Local resources" completes, the Output pane is concluded by calling
End()which shows "---finished---" and similar text. Unfortunately, it also explicitly tells the ErrorList to appear, which doesn't make sense. This PR fixes that, but there could be a better re-design of how this all works and that's worth thinking through.I'm not able to reproduce Package Manager Console switches to the Error List window automatically Home#6408 but need to spend more time with a real-world EF6 and EFCore scenario to ensure that. I'm wondering if there's a fix that can help Package Manager Console (PMC) as well.
PR Checklist