Feature/multiarch docker #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuSkooler
approved these changes
Oct 15, 2023
tracker1
reviewed
Oct 17, 2023
| && pm2 start main.js \ | ||
| && mkdir -p /enigma-bbs-pre/art \ | ||
| && mkdir /enigma-bbs-pre/mods \ | ||
| && mkdir /enigma-bbs-pre/config \ | ||
| && cp -rp art/* ../enigma-bbs-pre/art/ \ | ||
| && cp -rp mods/* ../enigma-bbs-pre/mods/ \ | ||
| && cp -rp config/* ../enigma-bbs-pre/config/ \ | ||
| && apt-get remove build-essential python python3 libssl-dev git curl -y \ | ||
| && apt-get remove build-essential python3 libssl-dev git curl -y \ |
There was a problem hiding this comment.
Maybe consider a multi-stage build/runtime, as this doesn't decrease the actual download size for image slices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few improvements to the Docker build process, including:
These changes appear to also have fixed the issue with networking on the build along the way. See build (https://github.com/NuSkooler/enigma-bbs/actions/runs/6526380735) for a successful run.
Note I have not tried running these docker containers on real hardware yet, this needs to be tested.