Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: broaden region intersection with player #30

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

Restioson
Copy link
Contributor

This includes the player's blockpos and one block above it. Functionally, this lets the player stand on a farmland or path block, for example, and still modify the region sitting right on top of it (as would happen with a fullblock)

@Restioson Restioson requested a review from Gegy June 11, 2024 13:10
Copy link
Member

@Gegy Gegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a naming nit :)

@Restioson Restioson force-pushed the feat/broader-region-intersection branch from 1966031 to e605688 Compare June 16, 2024 12:00
@Restioson Restioson requested a review from Gegy June 16, 2024 12:00
@Restioson
Copy link
Contributor Author

I also modified the /map region remove here command in latest forcepush as I forgot to apply the changes

@Gegy Gegy merged commit 1d82c90 into NucleoidMC:1.20.4 Jun 16, 2024
1 check passed
@Restioson Restioson deleted the feat/broader-region-intersection branch June 16, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants