Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove all regions by name #31

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

Restioson
Copy link
Contributor

Fixes #21

Syntax is /map region remove all <marker>

Note: if this lands before #28, then #28 should be updated accordingly. Else, if #28 lands first, this PR must be updated before being merged.

@Restioson Restioson requested a review from Gegy June 16, 2024 12:01
@Gegy
Copy link
Member

Gegy commented Jun 16, 2024

Needs rebase :)

@Restioson Restioson force-pushed the feat/delete-all-with-name branch from 671908d to 96ae173 Compare June 16, 2024 12:35
@Restioson Restioson requested a review from Gegy June 16, 2024 12:35
@Restioson
Copy link
Contributor Author

Heads up that this may need a full (though small) re-review as I did a lil refactoring

@Gegy Gegy merged commit a37edaa into NucleoidMC:1.20.4 Jun 16, 2024
1 check passed
@Restioson Restioson deleted the feat/delete-all-with-name branch June 16, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Command] /map region remove all_with_name [marker_name]
2 participants