Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sword blocking to old combat #318

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haykam821
Copy link
Contributor

This pull request will be part of a series of changes to expand the old combat systems to bring it further in line with Minecraft 1.8.9's combat system. As part of this pull request, old combat will now add blocking to swords, with the following behaviors:

  • Blocks half damage in addition to a base of 0.5
  • Does not damage the sword when blocking
  • Blocks immediately, as opposed to after 0.25 seconds
  • Plays damage sounds as opposed to shield sounds

The plasmid:old_combat data component type introduced as part of this pull request should be considered an implementation detail. Games should not expect to persist this component as its format may change in the future.

@haykam821 haykam821 added the feature New feature or request label Jan 28, 2025
@haykam821 haykam821 marked this pull request as draft January 28, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant