Skip to content

Commit

Permalink
Disable the new potential taint prevention for now, until more testing
Browse files Browse the repository at this point in the history
  • Loading branch information
Numynum committed May 7, 2024
1 parent 265cfd0 commit e654571
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions core/BlizzardLoadoutChanger.lua
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,12 @@ function Module:UpdateLastSelectedSavedConfigID(configID)

-- this horrible workaround should not be needed once blizzard actually fires SELECTED_LOADOUT_CHANGED event
-- or you know.. realizes that it's possible for addons to change the loadout, but we can't do that without tainting all the things
local _ = ClassTalentFrame
and ClassTalentFrame.TalentsTab
and ClassTalentFrame.TalentsTab.LoadoutDropDown
and ClassTalentFrame.TalentsTab.LoadoutDropDown.SetSelectionID
and ClassTalentFrame.TalentsTab.LoadoutDropDown:SetSelectionID(configID);
local dropdown = ClassTalentFrame and ClassTalentFrame.TalentsTab and ClassTalentFrame.TalentsTab.LoadoutDropDown;
local _ = dropdown and dropdown.SetSelectionID and dropdown:SetSelectionID(configID);

if true then return end -- disable this for now, needs more testing
-- this seems to reduce the amount of tainted values, but I didn't really dig into it
local _ = ClassTalentFrame
and ClassTalentFrame.TalentsTab
and ClassTalentFrame.TalentsTab.LoadoutDropDown
and ClassTalentFrame.TalentsTab.LoadoutDropDown.DropDownControl
and secureSetNil(ClassTalentFrame.TalentsTab.LoadoutDropDown.DropDownControl, 'selectedValue');
local _ = dropdown and dropdown.DropDownControl and secureSetNil(dropdown.DropDownControl, 'selectedValue');
end

function Module:SPELLS_CHANGED()
Expand Down

0 comments on commit e654571

Please sign in to comment.