[16.0][MIG] account_reversal (reversal usability improvements) #1725
Conversation
rousseldenis
commented
Sep 19, 2023
•
rousseldenis
commented
- Adds reversal id field
|
Hi @eLBati, |
rousseldenis
force-pushed
the
16.0-mig-account-reversal-dro
branch
4 times, most recently
from
5a36227 to
403c1a3
Compare
|
Hello @rousseldenis, I just added a commit in order to fix #1761. Could you add it in the PR message? |
sbidoul
changed the title
|
I have pushed a couple of minor fixes and clarifications. I think it's ok to keep the module name as is to reduce migration burden for users of the module in older Odoo versions. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
sbidoul
removed
the
stale
There was a problem hiding this comment.
Tested on runboat with success.
- adding a checkbox and filter "to be reversed" on account moves. => OK
- allowing to add a line reason (the move reason already exists in core). => OK
- makes the reason for account entries visible for normal entries too. Not really tested.
The list of Entries to be reversed exists and in the list, the entry disappears once reversed. the info of the reversed entry is visible on both journal entries.
Works as expected.
|
This PR has the |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@vdewulf your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1725-by-vdewulf-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
…ed flag and reversal_id many2one (lp:c2c-addons/6.1 rev 5609)
* OCA Transbot updated translations from Transifex * Add option to reconcile the reversal move with the original move (OCA#387) * [IMP] account_reversal: Several improvements * Default date for reverse move is not start_date of the period following the period of the original move (and not the period following today's period) * Return form view of account.move if only 1 move is reversed * Add option to reconcile with the reversal entry. * [10.0][MIG] account_reversal migration * [CHG] skid Odoo method to allow better performance on huge volume
Currently translated at 86.7% (26 of 30 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_reversal Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_reversal/ar/
Currently translated at 100.0% (30 of 30 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_reversal Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_reversal/nl/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_reversal Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_reversal/
Migration to 16.0 by expanding core features adding: - The line reason to reversal - The 'To Be Reversed' field and filter - Displaying the move reason not only for invoices
This commit adds the `reversal_id` field in order to improve the UX of the move reversal functionality. The field has been added to the form view close to the `reversed_entry_id` field already present in the view. This commit also introduces a constraint preventing the user to flag a move as to be reversed when a non cancelled reversal move has already been created. This allows simplifying the domain used on the `to_be_reversed` filter. Finally, it also convert the deprecated `SavepointCase` test into a `TransactionCase` one. Fixes: OCA#1761
After this commit, the order is - To be reversed flag - Reversal Entry - Reversal of Before, the flag was between the entries which was weird.
sbidoul
force-pushed
the
16.0-mig-account-reversal-dro
branch
from
cfc1ec0 to
5d696bb
Compare
|
rebased to investigate the merge failure |
