Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] account_move_line_attachment_preview #1739

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Oct 9, 2023

Depends on OCA/knowledge#434

This module adds a Preview column in the Journal Items list (account_move_line).
On the Preview column, the link to the attachment (file) is shown, if file is present.
Click on the link to preview the attachment of the invoice/vendor bill.

On a large monitor, when the preview is opened, the attachment is displayed on the right side.
When the preview is opened on a smaller display, the attachment is opened on a new browser tab.

screenshot-split

@astirpe astirpe force-pushed the 16_add_account_move_line_attachment_preview branch 4 times, most recently from 437e7d6 to 573275c Compare October 9, 2023 14:52
Copy link
Member

@houzefa-abba houzefa-abba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I skimmed through the code, looks all good to me!

Later on I guess we might be able to factor out a few things in JS & CSS code between this module and attachment_preview itself

@astirpe astirpe force-pushed the 16_add_account_move_line_attachment_preview branch 3 times, most recently from 95bed35 to 1b4d4ce Compare October 10, 2023 06:54
@astirpe astirpe marked this pull request as ready for review October 10, 2023 07:00
@astirpe astirpe force-pushed the 16_add_account_move_line_attachment_preview branch from 1b4d4ce to f78b094 Compare October 10, 2023 07:09
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, works perfectly!

Copy link

@yung-wang yung-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, works fine

@sbidoul sbidoul added this to the 16.0 milestone Jan 1, 2024
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2024
@bosd
Copy link
Contributor

bosd commented Oct 15, 2024

Uh ooh.. don't go stale...

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 20, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants