-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] account_move_line_attachment_preview #1739
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] account_move_line_attachment_preview #1739
Conversation
437e7d6
to
573275c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I skimmed through the code, looks all good to me!
Later on I guess we might be able to factor out a few things in JS & CSS code between this module and attachment_preview
itself
95bed35
to
1b4d4ce
Compare
1b4d4ce
to
f78b094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally, works perfectly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, works fine
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Uh ooh.. don't go stale... |
This PR has the |
Depends on OCA/knowledge#434
This module adds a Preview column in the Journal Items list (account_move_line).
On the Preview column, the link to the attachment (file) is shown, if file is present.
Click on the link to preview the attachment of the invoice/vendor bill.
On a large monitor, when the preview is opened, the attachment is displayed on the right side.
When the preview is opened on a smaller display, the attachment is opened on a new browser tab.